Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Targeting support #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RFC: Targeting support #166

wants to merge 2 commits into from

Conversation

koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Aug 2, 2017 •
edited
Loading

I'm not sure if using nested props is the right approach, so if you have any suggestions, please let me know!

Maybe an imperative API in the form of passing arguments to loadBanner is more suitable?

Edit: or maybe just a "standalone" API to set these properties, as they are not expected to change very often in a session (I presume).

This would be a fix for #98, so maybe @vseprav wants to chime in as well?

@koenpunt koenpunt mentioned this pull request Aug 2, 2017
Merged
9 tasks
@koenpunt koenpunt requested a review from alvaromb August 2, 2017 22:23
@koenpunt koenpunt force-pushed the next branch 4 times, most recently from e864ac4 to 6b7e96c Compare September 28, 2017 13:36
@koenpunt koenpunt mentioned this pull request Sep 28, 2017
Closed
@koenpunt koenpunt changed the title Proposal: Targeting support RFC: Targeting support Sep 28, 2017
@koenpunt koenpunt changed the base branch from next to master October 3, 2017 20:22
@kaanduraa
Copy link

Any updates on Android targeting ?

@koenpunt
Copy link
Collaborator Author

koenpunt commented Oct 4, 2017

Any updates on Android targeting ?

I first want to settle the API before starting development for Android.

@kaanduraa
Copy link

Thanks for the reply, I need targeting in my project very badly because my users are the same type. Perhaps I can help you out?

@koenpunt koenpunt mentioned this pull request Oct 4, 2017
Closed
@engvik
Copy link

engvik commented Nov 8, 2017 •
edited
Loading

Hi! Any progress on this? Would love to see this happening 😄

And let me know if there's anything I can help with in the Android part.

@koenpunt koenpunt mentioned this pull request Dec 20, 2017
Open
@marudy
Copy link

marudy commented Dec 30, 2017

Hello!

Happy holidays and a happy fruitful new year to everyone!

Any progress regarding this? I would also like to see this happening and implement in my Android game 😃

@koenpunt koenpunt mentioned this pull request Mar 10, 2018
Closed
@davidepalazzo
Copy link

Hey guys,

Just wondering is there any update on this feature?

Thanks!

@shukerullah
Copy link

Any update on this?

@Bitterballs
Copy link

Is there a update already?

@chsjr1996 chsjr1996 mentioned this pull request Sep 12, 2019
Open
@chsjr1996
Copy link

Hey people, i made this pull request to allow targeting in Android too.

#469

@koenpunt
Proposal: Targeting support
6c5baa2 
I'm not sure if using nested prop is the right approach, so if you have any suggestions, please let me know!
@KVinS
Copy link

KVinS commented Aug 2, 2020

@koenpunt hello.
In fact, now all applications containing the plugin violate the law due to the use of personal data.
Maybe it is possible to do at least support for the npa flag?
How did ammarahm-ed do it

2020-08-02_04-12-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaromb alvaromb Awaiting requested review from alvaromb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@koenpunt @kaanduraa @engvik @marudy @davidepalazzo @shukerullah @Bitterballs @chsjr1996 @KVinS